[AMD] chore(config): use a more up to date container for rocm/sgl#200
[AMD] chore(config): use a more up to date container for rocm/sgl#200loicdesirest wants to merge 1 commit intoSemiAnalysisAI:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates Docker image references for AMD ROCm configurations from an older format (rocm/7.0:rocm7.0_ubuntu_22.04_sgl-dev-v0.5.2-rocm7.0-*) to a newer format (rocm/sgl-dev:v0.5.5-rocm700-*), upgrading from sglang v0.5.2 to v0.5.5.
- Updates four sglang-based configurations to use newer Docker images
- Changes image naming convention to a more compact format
- Updates the date suffix from 20250915 to 20251107
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| dsr1-fp8-mi325x-sglang: | ||
| image: rocm/7.0:rocm7.0_ubuntu_22.04_sgl-dev-v0.5.2-rocm7.0-mi30x-20250915 | ||
| image: rocm/sgl-dev:v0.5.5-rocm700-mi30x-20251107 |
There was a problem hiding this comment.
The image tag uses 'mi30x' but this configuration is for the 'mi325x' runner (line 48). This mismatch could result in using an incompatible Docker image. The tag should be 'mi32x' or 'mi325x' to match the runner hardware.
| image: rocm/sgl-dev:v0.5.5-rocm700-mi30x-20251107 | |
| image: rocm/sgl-dev:v0.5.5-rocm700-mi32x-20251107 |
|
waiting on @ChrisMasonAMD |
|
AMD working on it here https://github.com/InferenceMAX/InferenceMAX/pull/247 |
|
Thanks @functionstackx I'll close this PR then! |
cquil11
changed the title
Looking at the rocm page on docker hub, I noticed there is a container for sglang and MI3XX series that is updated way more frequently than the one used in this repo.
Is there any reason for the other container to be used instead?