Skip to content

[AMD] chore(config): use a more up to date container for rocm/sgl #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
loicdesirest wants to merge 1 commit into from
Closed

[AMD] chore(config): use a more up to date container for rocm/sgl #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/configs/amd-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
dsr1-fp4-mi355x-sglang:
image: rocm/7.0:rocm7.0_ubuntu_22.04_sgl-dev-v0.5.2-rocm7.0-mi35x-20250915
image: rocm/sgl-dev:v0.5.5-rocm700-mi35x-20251107
model: amd/DeepSeek-R1-0528-MXFP4-Preview
model-prefix: dsr1
runner: mi355x
Expand All @@ -21,7 +21,7 @@ dsr1-fp4-mi355x-sglang:
- { tp: 8, conc-start: 4, conc-end: 64 }

dsr1-fp8-mi300x-sglang:
image: rocm/7.0:rocm7.0_ubuntu_22.04_sgl-dev-v0.5.2-rocm7.0-mi30x-20250915
image: rocm/sgl-dev:v0.5.5-rocm700-mi30x-20251107
model: deepseek-ai/DeepSeek-R1-0528
model-prefix: dsr1
runner: mi300x
Expand All @@ -42,7 +42,7 @@ dsr1-fp8-mi300x-sglang:
- { tp: 8, conc-start: 4, conc-end: 64 }

dsr1-fp8-mi325x-sglang:
image: rocm/7.0:rocm7.0_ubuntu_22.04_sgl-dev-v0.5.2-rocm7.0-mi30x-20250915
image: rocm/sgl-dev:v0.5.5-rocm700-mi30x-20251107
Copy link

Copilot AI Nov 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image tag uses 'mi30x' but this configuration is for the 'mi325x' runner (line 48). This mismatch could result in using an incompatible Docker image. The tag should be 'mi32x' or 'mi325x' to match the runner hardware.

Suggested change
image: rocm/sgl-dev:v0.5.5-rocm700-mi30x-20251107
image: rocm/sgl-dev:v0.5.5-rocm700-mi32x-20251107

Copilot uses AI. Check for mistakes.
model: deepseek-ai/DeepSeek-R1-0528
model-prefix: dsr1
runner: mi325x
Expand All @@ -63,7 +63,7 @@ dsr1-fp8-mi325x-sglang:
- { tp: 8, conc-start: 4, conc-end: 64 }

dsr1-fp8-mi355x-sglang:
image: rocm/7.0:rocm7.0_ubuntu_22.04_sgl-dev-v0.5.2-rocm7.0-mi35x-20250915
image: rocm/sgl-dev:v0.5.5-rocm700-mi35x-20251107
model: deepseek-ai/DeepSeek-R1-0528
model-prefix: dsr1
runner: mi355x
Expand Down