Skip to content

Require diff-reading on PR re-reviews#503

Merged
jlamypoirier merged 1 commit intomainfrom
jlp_review-diff-discipline
Apr 30, 2026
Merged

Require diff-reading on PR re-reviews#503
jlamypoirier merged 1 commit intomainfrom
jlp_review-diff-discipline

Conversation

@jlamypoirier
Copy link
Copy Markdown
Collaborator

Summary

  • Adds a Diff discipline bullet to the existing "PR review focus" section of CLAUDE.md.
  • Closes a real gap surfaced in a recent review session: on a follow-up after fixes, the reviewer leaned on commit messages and git --stat summaries, claimed "all fixes verified", and missed two real issues (one bug introduced by the rename commit, one type-annotation inconsistency).
  • The new bullet forbids substituting commit messages or --stat for the actual diff, and forbids ✅-stamping items whose diff hasn't been read.

Test plan

  • Skim the rendered CLAUDE.md in the PR preview to confirm the bullet sits cleanly in the existing section.

🤖 Generated with Claude Code

Reviewers (human or /review) sometimes substitute commit messages or
git --stat for actually reading the code, especially on follow-up
reviews after fixes. The new bullet makes diff-reading explicit and
forbids ✅-stamping items whose diff hasn't been read.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@jlamypoirier jlamypoirier merged commit 79433c8 into main Apr 30, 2026
2 checks passed
@jlamypoirier jlamypoirier deleted the jlp_review-diff-discipline branch April 30, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant