Skip to content

Require diff-reading on PR re-reviews #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jlamypoirier merged 1 commit into from
Apr 30, 2026
+1 −0
Merged

Require diff-reading on PR re-reviews #503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,3 +187,4 @@ When reviewing PRs (`/review` reads this section as part of its checklist):
- **Simplification**: actively look for non-trivial simplifications and refactoring opportunities, not just style nitpicks.
- **Correctness**: edge cases, off-by-ones, error handling, race conditions. Read the code; don't trust comments.
- **Test coverage**: new code paths should have tests; modified behavior should have updated tests. Untested control flow is a flag.
- **Diff discipline**: don't substitute commit messages or `git --stat` for reading the code. On a follow-up review after fixes, read `git diff <last-reviewed-sha>..HEAD` in full before claiming an item is "verified" or "fixed". Never put ✅ on items whose diff you haven't read.
Loading