Merged
Conversation
migrating from one big glob of test data to more modular per-test input and output data as RDS files
also standardize the file paths of the shared example dataaset as "data/..." instead of doing a weird hacky basename() that confused things
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using one big glob of data generated at package load time for both code examples and unit tests (
test_datafromR/zz_helper_data.R) was a mess and getting hard to maintain. This splits away the unit tests to be more modular and mostly driven by saved RDS files for input and expected outputs. Later I expect to get rid of thetest_dataobject entirely and replace it with a saved dataset like Hadley suggests.