This repository was archived by the owner on Aug 13, 2025. It is now read-only.
define with-float-traps-masked and tests#11
Merged
Shinmera merged 3 commits intoShinmera:masterfrom Apr 2, 2020
Merged
Conversation
Contributor
kpoeck
commented
Apr 1, 2020
- define finally with-float-traps-masked for clasp
- added tests
- tested in ecl, ccl, clasp and sbcl
Shinmera
suggested changes
Apr 1, 2020
Contributor
Author
|
I hope I have now applied all your comments, apart from :denormalized-operand. Clasp supports setting the flag for :denormalized-operand, see https://github.com/clasp-developers/clasp/blob/dev/src/gctools/interrupt.cc#L264 But the possible codes for sigfpe are defined in the headers like this: #if !defined(_POSIX_C_SOURCE) || defined(_DARWIN_C_SOURCE)
#define FPE_NOOP 0 /* if only I knew... */
#endif
#define FPE_FLTDIV 1 /* [XSI] floating point divide by zero */
#define FPE_FLTOVF 2 /* [XSI] floating point overflow */
#define FPE_FLTUND 3 /* [XSI] floating point underflow */
#define FPE_FLTRES 4 /* [XSI] floating point inexact result */
#define FPE_FLTINV 5 /* [XSI] invalid floating point operation */
#define FPE_FLTSUB 6 /* [XSI] subscript out of range -NOTIMP */
#define FPE_INTDIV 7 /* [XSI] integer divide by zero */
#define FPE_INTOVF 8 /* [XSI] integer overflow */Since here I could not find |
Contributor
Author
|
Here the test-log for ecl, sbcl, ccl and clasp: FLOAT-FEATURES-TESTS::FLOAT-FEATURES-INVALID-TRAPPED fails in ecl. If in the same session I execute the tests again, all tests work |
Owner
|
Looks good, thanks a lot! |
Contributor
Author
|
great! |
Shinmera
added a commit
to Shinmera/portability
that referenced
this pull request
Apr 2, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.