This repository was archived by the owner on Aug 13, 2025. It is now read-only.
Merged
Conversation
Removes temporary functions, since they could be inlined anyway. Uses SYMBOL-VALUE to preven constant-folding similarly to READ-FROM-STRING.
Owner
|
Thanks for this as well! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(For reference, tests that are modified by this pull request were introduced in #11.)
When compiling/running tests, warnings are signaled due to
foo-...andbar-...functions having an unused argument.This updates those tests by removing temporary functions
foo-...andbar-..., as well as localfooandbarin analogous tests. It seems that their only purpose is to prevent constant folding, but it doesn't work well since they can be inlined. Instead,read-from-stringandsymbol-valueare used to prevent constant folding.