This repository was archived by the owner on Aug 30, 2018. It is now read-only.
Fix iOS Safari off canvas scaling issues#518
Merged
cshold merged 2 commits intoShopify:masterfrom Mar 2, 2016
cam:iOS-viewport-patch
Merged
Fix iOS Safari off canvas scaling issues#518cshold merged 2 commits intoShopify:masterfrom cam:iOS-viewport-patch
cshold merged 2 commits intoShopify:masterfrom
cam:iOS-viewport-patch
Conversation
added 2 commits
March 2, 2016 12:41
This fixes the changes in the way Safari interprets zooming and overflow on objects. As Apple consider their changes to be the right way to do things, they probably aren’t going to be changing the behaviour any time soon.
This fixes the changes in the way Safari interprets zooming and overflow on objects. As Apple consider their changes to be the right way to do things, they probably aren’t going to be changing the behaviour any time soon.
Contributor
|
Thank you for bringing this up. I'd been searching for a fix but never came across For those wondering exactly what this fixes, see what happens in our Brooklyn theme when you close the navigation drawer (on iOS 9): With this fix, you get a nice smooth drawer closing: |
cshold
added a commit
that referenced
this pull request
Mar 2, 2016
Fix iOS Safari off canvas scaling issues
Author
|
@cshold Apple are apparently taking an ideological stand on how viewport overflows should work :/ |
Contributor
|
Chrome gives a little warning, but small price to pay for iOS to be happy.
|
Author
|
Yeah that seems like a small price to pay. Looks like it will be addressed in Chromium :) https://bugs.chromium.org/p/chromium/issues/detail?id=569649 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the changes in the way Safari interprets zooming and overflow on objects. As Apple consider their changes to be the right way to do things, they probably aren’t going to be changing the behaviour any time soon.