This repository was archived by the owner on Jun 13, 2018. It is now read-only.
Use multiple attempted delivery codes for USPS tracking#361
Merged
jonathankwok merged 1 commit intomasterfrom Apr 26, 2016
Merged
Use multiple attempted delivery codes for USPS tracking#361jonathankwok merged 1 commit intomasterfrom
jonathankwok merged 1 commit intomasterfrom
Conversation
Contributor
|
🐑 🇮🇹 |
Contributor
|
🚢 |
jonathankwok
force-pushed
the
better-detect-usps-attempted-delivery
branch
from
6da2c78 to
21f2c50
Compare
Contributor
|
Nice find! 👍 |
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
…ivery Use multiple attempted delivery codes for USPS tracking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
There are multiple possible
attempted_deliverycodes - see page 335 of this, or look at this screenshot:There are multiple codes for "Notice Left"/Attempted Delivery - rather than just use code 55, use all of the ones in the appendix. Code H0 came from me finding responses manually through a database of tracking codes, seems to also be Attempted Delivery (unsurprisingly not documented).
Changes
Add an array of known
ATTEMPTED_DELIVERY_CODESand check for inclusion when saving theattempted_delivery_date.This fixes part of the red build, which doesn't actually depend on this fix - it was just an outdated tracking number. The other half is fixed by #362
Review: @kmcphillips @RichardBlair @mdking @MalazAlamir