This repository was archived by the owner on Jun 13, 2018. It is now read-only.
Take into account business hours for UPS delivery estimates#362
Merged
jonathankwok merged 1 commit intomasterfrom Apr 26, 2016
Merged
Take into account business hours for UPS delivery estimates#362jonathankwok merged 1 commit intomasterfrom
jonathankwok merged 1 commit intomasterfrom
Conversation
Contributor
|
|
Contributor
|
🚢 |
maartenvg
pushed a commit
that referenced
this pull request
Nov 9, 2017
Take into account business hours for UPS delivery estimates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Time zone shiftiness going on:
from_nowjust adds the n days, whereas.aftertakes into account business hours, adding an extra day if the present time is past business hours (which is why it's flaky right now, since most of the time we're running our builds outside of business hours for the system (UTC)).Carrier responses take into account business time and rolling forward, so we should too in our tests.
Fixes half of the red build - the other half is fixed by #361
Review: @kmcphillips @RichardBlair @mdking @MalazAlamir