Simbe-specific modifications #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cemersoz
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potentially better way to do this would be sending the conffile in a separate ptpd-simbe-conf package or via ansible, but since this is a dead package anyway, it doesn't super matter. Basically there's very little difference between what's in Jan's
ptpd.confand what the project ships as https://github.com/SimbeRobotics/ptpd/blob/simbe-devel/src/ptpd2.conf.default-full, I think it's really just pointing it ateth0as the interface to use. 😂Anyway, let's keep things simple. Once this is merged, I'll tag it with
2.3.1-debian1-4build2-simbe0and that'll go to gemfury from which we can easily pull it to bots or include it in the base image.