Changed timestamp to ISO8601 format with milliseconds.#2
Merged
Conversation
Owner
|
LGTM. i will bump the major version since it breaking |
Owner
|
this is now deployed |
Contributor
Author
|
Awesome, thank you! I will unlist the above referenced temporary NuGet package. |
Owner
|
BTW i also added support for dotnet build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I came across your library and it was exactly the solution I envisioned, using Fody. I am needing a timestamp that will function for multiple builds per day, so I added ISO8601 format with milliseconds in this pull request.
Please consider this PR. I realize that it does break or potentially break existing usage that may be expecting just a yyyy-MM-dd format. I'm willing to make changes at your suggestion.
In the meantime, I have uploaded a build of this to Nuget at https://www.nuget.org/packages/BuildTimestamp/0.3.2 if it may be useful to anyone else.