Hotfix: preserve step cache for all followup calls#1016
Merged
Conversation
Contributor
luhmirin-s
commented
Dec 10, 2024
luhmirin-s
commented
- With the introduction of matching modalities, callout sequence "identify->confirm->enrol last" led to an unexpected double capture.
- The issue was caused by the step cache being re-written to contain only "confirm" callout steps by the time "enrol last" is called.
- Steps of each new callout are being appended to the already cached steps. Since old steps are in "COMPLETE" step, it does not interfere with the currently executing steps.
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
meladRaouf
approved these changes
Dec 10, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.