Skip to content

Hotfix: preserve step cache for all followup calls #1016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 1 commit into from
Dec 10, 2024
Merged

Hotfix: preserve step cache for all followup calls #1016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...re/orchestrator/src/main/java/com/simprints/feature/orchestrator/OrchestratorViewModel.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,9 @@ internal class OrchestratorViewModel @Inject constructor(
actionRequest = action

try {
steps = stepsBuilder.build(action, projectConfiguration)
// We must preserve all of the steps across multiple callouts in to correctly
// resolve missing modality capture in enrol last followup call.
steps = cache.steps + stepsBuilder.build(action, projectConfiguration)
} catch (e: SubjectAgeNotSupportedException) {
sendErrorResponse(AppErrorResponse(AppErrorReason.AGE_GROUP_NOT_SUPPORTED))
return@launch
Expand Down
19 changes: 0 additions & 19 deletions ...rchestrator/src/test/java/com/simprints/feature/orchestrator/OrchestratorViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,29 +348,10 @@ internal class OrchestratorViewModelTest {
every { cache.steps } returns savedSteps

viewModel.handleAction(mockk())
viewModel.restoreStepsIfNeeded()

verify { cache.steps }
}

@Test
fun `Does not restore steps if not empty`() = runTest {
val originalSteps = listOf(
createMockStep(StepId.FINGERPRINT_CAPTURE),
)
every { stepsBuilder.build(any(), any()) } returns originalSteps
val savedSteps = listOf(
createMockStep(StepId.SETUP),
createMockStep(StepId.CONSENT),
)
every { cache.steps } returns savedSteps

viewModel.handleAction(mockk())
viewModel.restoreStepsIfNeeded()

verify(exactly = 0) { cache.steps }
}

@Test
fun `Restores modalities if empty`() = runTest {
val projectModalities = listOf<GeneralConfiguration.Modality>(
Expand Down