Skip to content

MS-1225 Do not reset local data when sync frequency changes#1437

Merged
luhmirin-s merged 1 commit into
release/2025.3.0from
hotfix/MS-1225-stricter-data-reset-check
Oct 29, 2025
Merged

MS-1225 Do not reset local data when sync frequency changes#1437
luhmirin-s merged 1 commit into
release/2025.3.0from
hotfix/MS-1225-stricter-data-reset-check

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s commented Oct 29, 2025

JIRA ticket
Will be released in: 2025.3.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.3.0

  • Data reset was triggered on any change within down.simprints configuration

Notable changes

  • Remove the full object comparison from the check; we only care about partitioning.
  • Add unit test to ensure frequency checks do not trigger the wipe.

Testing guidance

  • Set the project to sync periodically.
  • Create some local data.
  • Change to another sync frequency and sync configuration.
  • Check that all are present on device and were not re-downloaded

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)
  • Other teams notified about the changes (if applicable)

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team October 29, 2025 15:11
@cla-bot cla-bot Bot added the ... label Oct 29, 2025
}

@Test
fun `should not reset local records when sync frequency changes`() = runTest {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add tests (or update this one) to check that other fields inside simprints don't cause a reset, just in case.

@luhmirin-s luhmirin-s force-pushed the hotfix/MS-1225-stricter-data-reset-check branch from 1cd90d4 to 5b202f5 Compare October 29, 2025 15:23
@sonarqubecloud
Copy link
Copy Markdown

@luhmirin-s luhmirin-s merged commit 3f77a6a into release/2025.3.0 Oct 29, 2025
13 checks passed
@luhmirin-s luhmirin-s deleted the hotfix/MS-1225-stricter-data-reset-check branch October 29, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants