Skip to content

MS-1225 Do not reset local data when sync frequency changes #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luhmirin-s merged 1 commit into from
Oct 29, 2025
Merged

MS-1225 Do not reset local data when sync frequency changes #1437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...n/java/com/simprints/infra/sync/config/usecase/ResetLocalRecordsIfConfigChangedUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,15 @@ internal class ResetLocalRecordsIfConfigChangedUseCase @Inject constructor(
}
}

//
private fun hasPartitionTypeChanged(
oldConfig: ProjectConfiguration,
newConfig: ProjectConfiguration,
) = (oldConfig.synchronization.down.commCare != newConfig.synchronization.down.commCare) ||
(oldConfig.synchronization.down.simprints != newConfig.synchronization.down.simprints) ||
(oldConfig.synchronization.down.simprints?.partitionType != newConfig.synchronization.down.simprints?.partitionType)
// This also covers simprints changing from/to null since the partition will always be present if simprints is
(
oldConfig.synchronization.down.simprints
?.partitionType != newConfig.synchronization.down.simprints
?.partitionType
)
}
132 changes: 130 additions & 2 deletions ...va/com/simprints/infra/sync/config/usecase/ResetLocalRecordsIfConfigChangedUseCaseTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
package com.simprints.infra.sync.config.usecase

import com.simprints.core.domain.tokenization.asTokenizableEncrypted
import com.simprints.infra.config.store.models.DownSynchronizationConfiguration
import com.simprints.infra.config.store.models.Frequency
import com.simprints.infra.enrolment.records.repository.EnrolmentRecordRepository
import com.simprints.infra.eventsync.EventSyncManager
import com.simprints.infra.sync.SyncOrchestrator
Expand Down Expand Up @@ -106,14 +108,15 @@ class ResetLocalRecordsIfConfigChangedUseCaseTest {
simprints = synchronizationConfiguration.down.simprints?.copy(
partitionType = DownSynchronizationConfiguration.PartitionType.PROJECT,
),
commCare = null,
),
),
),
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = null,
commCare = DownSynchronizationConfiguration.CommCareDownSynchronizationConfiguration
commCare = DownSynchronizationConfiguration.CommCareDownSynchronizationConfiguration,
),
),
),
Expand All @@ -134,7 +137,7 @@ class ResetLocalRecordsIfConfigChangedUseCaseTest {
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = null,
commCare = DownSynchronizationConfiguration.CommCareDownSynchronizationConfiguration
commCare = DownSynchronizationConfiguration.CommCareDownSynchronizationConfiguration,
),
),
),
Expand All @@ -144,6 +147,7 @@ class ResetLocalRecordsIfConfigChangedUseCaseTest {
simprints = synchronizationConfiguration.down.simprints?.copy(
partitionType = DownSynchronizationConfiguration.PartitionType.PROJECT,
),
commCare = null,
),
),
),
Expand All @@ -156,4 +160,128 @@ class ResetLocalRecordsIfConfigChangedUseCaseTest {
enrolmentRecordRepository.deleteAll()
}
}

@Test
fun `should not reset local records when sync frequency changes`() = runTest {
Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add tests (or update this one) to check that other fields inside simprints don't cause a reset, just in case.

useCase(
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
frequency = Frequency.ONLY_PERIODICALLY_UP_SYNC,
),
),
),
),
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
frequency = Frequency.PERIODICALLY,
),
),
),
),
)

coVerify(exactly = 0) {
syncOrchestrator.cancelEventSync()
syncOrchestrator.rescheduleEventSync()
eventSyncManager.resetDownSyncInfo()
enrolmentRecordRepository.deleteAll()
}
}

@Test
fun `should not reset local records when sync modules changes`() = runTest {
useCase(
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
moduleOptions = listOf("One".asTokenizableEncrypted(), "Two".asTokenizableEncrypted()),
),
),
),
),
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
moduleOptions = listOf("Three".asTokenizableEncrypted()),
),
),
),
),
)

coVerify(exactly = 0) {
syncOrchestrator.cancelEventSync()
syncOrchestrator.rescheduleEventSync()
eventSyncManager.resetDownSyncInfo()
enrolmentRecordRepository.deleteAll()
}
}

@Test
fun `should not reset local records when sync max age changes`() = runTest {
useCase(
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
maxAge = "PT24H",
),
),
),
),
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
maxAge = "PT12H",
),
),
),
),
)

coVerify(exactly = 0) {
syncOrchestrator.cancelEventSync()
syncOrchestrator.rescheduleEventSync()
eventSyncManager.resetDownSyncInfo()
enrolmentRecordRepository.deleteAll()
}
}

@Test
fun `should not reset local records when sync module count changes`() = runTest {
useCase(
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
maxNbOfModules = 2,
),
),
),
),
projectConfiguration.copy(
synchronization = synchronizationConfiguration.copy(
down = synchronizationConfiguration.down.copy(
simprints = synchronizationConfiguration.down.simprints?.copy(
maxNbOfModules = 5,
),
),
),
),
)

coVerify(exactly = 0) {
syncOrchestrator.cancelEventSync()
syncOrchestrator.rescheduleEventSync()
eventSyncManager.resetDownSyncInfo()
enrolmentRecordRepository.deleteAll()
}
}
}