[MS-1216] ] Call viewModel.start() only on first creation of SetupFragment

[meladRaouf]

JIRA ticket
Will be released in: 2025.4.0

Root cause analysis (for bugfixes only)

First known affected version: all releases

• Changes

Fixes a bug where rotating the device with a permission dialogue (location/notification) open would cause the setup flow to advance to the next screen while the dialogue remained visible.

This was caused by the permission request event re-firing on a configuration change. The fix ensures the viewmodel.start() is only called once

Before:
https://github.com/user-attachments/assets/161bcb77-3a7f-46bb-ba47-7691d19f526b
After:
https://github.com/user-attachments/assets/94554884-fb37-47de-b4e1-0e5b3f253f77

Testing guidance

• Start any flow (ensure Location and Notification permissions are not yet granted).
• The "Location" permission dialog should appear.
• Rotate the screen (dialog is on-screen).
• Observe the bug: The flow underneath navigates to the Consent Screen while the location dialog remains, now floating over it.

Additional work checklist

• Effect on other features and security has been considered
• Design document marked as "In development" (if applicable)
• External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
• Test cases in Testiny are up to date (or ticket created)
• Other teams notified about the changes (if applicable)

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud