Skip to content

[MS-1216] ] Call viewModel.start() only on first creation of SetupFragment #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meladRaouf merged 1 commit into from
Nov 4, 2025
Merged

[MS-1216] ] Call viewModel.start() only on first creation of SetupFragment #1447

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion feature/setup/src/main/java/com/simprints/feature/setup/screen/SetupFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,9 @@ internal class SetupFragment : Fragment(R.layout.fragment_setup) {
// Overall setup result
observeOverallSetupResult()
// Start the setup process
viewModel.start()
if (savedInstanceState == null) {
viewModel.start()
}
}

private fun observeOverallSetupResult() = viewModel.overallSetupResult.observe(viewLifecycleOwner) {
Expand Down
30 changes: 25 additions & 5 deletions feature/setup/src/test/java/com/simprints/feature/setup/screen/SetupViewModelTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,11 @@ class SetupViewModelTest {
fun `should not request location permission if collectLocation is disabled`() = runTest {
// Given
coEvery { configManager.getProjectConfiguration().general.collectLocation } returns false
coEvery { configManager.getProjectConfiguration().synchronization.down.commCare } returns mockk()
coEvery {
configManager
.getProjectConfiguration()
.synchronization.down.commCare
} returns mockk()

// when
viewModel.start()
Expand All @@ -95,7 +99,11 @@ class SetupViewModelTest {
// Given
justRun { locationStore.collectLocationInBackground() }
coEvery { configManager.getProjectConfiguration() } returns mockk<ProjectConfiguration>()
coEvery { configManager.getProjectConfiguration().synchronization.down.commCare } returns mockk()
coEvery {
configManager
.getProjectConfiguration()
.synchronization.down.commCare
} returns mockk()

// when
viewModel.locationPermissionCheckDone(granted = true)
Expand All @@ -109,7 +117,11 @@ class SetupViewModelTest {
// Given
justRun { locationStore.collectLocationInBackground() }
coEvery { configManager.getProjectConfiguration() } returns mockk<ProjectConfiguration>()
coEvery { configManager.getProjectConfiguration().synchronization.down.commCare } returns mockk()
coEvery {
configManager
.getProjectConfiguration()
.synchronization.down.commCare
} returns mockk()

// when
viewModel.locationPermissionCheckDone(granted = false)
Expand All @@ -122,7 +134,11 @@ class SetupViewModelTest {
fun `should request CommCare permission if needed when location permission is granted`() = runTest {
// Given
justRun { locationStore.collectLocationInBackground() }
coEvery { configManager.getProjectConfiguration().synchronization.down.commCare } returns mockk()
coEvery {
configManager
.getProjectConfiguration()
.synchronization.down.commCare
} returns mockk()

// When
viewModel.locationPermissionCheckDone(true)
Expand All @@ -135,7 +151,11 @@ class SetupViewModelTest {
fun `should request CommCare permission if needed when location permission is not granted`() = runTest {
// Given
justRun { locationStore.collectLocationInBackground() }
coEvery { configManager.getProjectConfiguration().synchronization.down.commCare } returns mockk()
coEvery {
configManager
.getProjectConfiguration()
.synchronization.down.commCare
} returns mockk()

// When
viewModel.locationPermissionCheckDone(false)
Expand Down