Skip to content

[MS-1240] Explicitly stopping camera on External Credential QR screen on pause#1461

Merged
alexandr-simprints merged 1 commit into
release/2025.4.0from
MS-1240-mf-id-qr-scanner-stuck-after-leaving-the-app-or-many-bad-scans
Nov 10, 2025
Merged

[MS-1240] Explicitly stopping camera on External Credential QR screen on pause#1461
alexandr-simprints merged 1 commit into
release/2025.4.0from
MS-1240-mf-id-qr-scanner-stuck-after-leaving-the-app-or-many-bad-scans

Conversation

@alexandr-simprints
Copy link
Copy Markdown
Contributor

JIRA ticket
Will be released in: 2025.4.0

Root cause analysis (for bugfixes only)

First known affected version: 2025.4.0
QR code analyzer stopped picking up images once the user returns to SID from another app. I wasn't able to reproduce the issue on any device, I'd be glad if @meladRaouf could test this solution before merging.

Notable changes

  • CameraHelper can now be explicitly unbind
  • External Credential QR scanner screen unbinds the camera in onPause, and re-initializes it in onResume

Testing guidance

  • Open External Credential QR scanner screen
  • Leave the app
  • Return to the app
  • Make sure different QR codes are being automatically picked up once pointed at

Additional work checklist

  • Effect on other features and security has been considered
  • Design document marked as "In development" (if applicable)
  • External (Gitbook) and internal (Confluence) Documentation is up to date (or ticket created)
  • Test cases in Testiny are up to date (or ticket created)

@cla-bot cla-bot Bot added the ... label Nov 10, 2025
@alexandr-simprints alexandr-simprints marked this pull request as draft November 10, 2025 12:08
@sonarqubecloud
Copy link
Copy Markdown

@alexandr-simprints alexandr-simprints marked this pull request as ready for review November 10, 2025 13:07
@alexandr-simprints
Copy link
Copy Markdown
Contributor Author

@meladRaouf has confirmed that these changes fix the QR code scanner issue

@alexandr-simprints alexandr-simprints merged commit 0be0017 into release/2025.4.0 Nov 10, 2025
13 checks passed
@alexandr-simprints alexandr-simprints deleted the MS-1240-mf-id-qr-scanner-stuck-after-leaving-the-app-or-many-bad-scans branch November 10, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants