Skip to content

[MS-1240] Explicitly stopping camera on External Credential QR screen on pause #1461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandr-simprints merged 1 commit into from
Nov 10, 2025
Merged

[MS-1240] Explicitly stopping camera on External Credential QR screen on pause #1461

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions ...m/simprints/feature/externalcredential/screens/scanqr/ExternalCredentialScanQrFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,15 +87,23 @@ internal class ExternalCredentialScanQrFragment : Fragment(R.layout.fragment_ext
}
}

override fun onPause() {
if (isCameraInitialized) {
cameraHelper.stopCamera()
isCameraInitialized = false
}
super.onPause()
}

override fun onResume() {
super.onResume()
val cameraPermissionStatus = requireActivity().getCurrentPermissionStatus(CAMERA)
viewModel.updateCameraPermissionStatus(cameraPermissionStatus)
}

override fun onDestroy() {
override fun onDestroyView() {
dismissDialog()
super.onDestroy()
super.onDestroyView()
}

private fun dismissDialog() {
Expand Down
2 changes: 2 additions & 0 deletions feature/external-credential/src/main/res/layout/fragment_external_credential_scan_qr.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@
android:layout_width="wrap_content"
android:layout_height="wrap_content"
android:layout_margin="8dp"
android:ellipsize="end"
android:maxLines="3"
tools:text="QR_CODE" />
</com.google.android.material.card.MaterialCardView>

Expand Down
16 changes: 13 additions & 3 deletions infra/ui-base/src/main/java/com/simprints/infra/uibase/camera/qrscan/CameraHelper.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class CameraHelper @AssistedInject constructor(
private val cameraFocusManagerFactory: CameraFocusManager.Factory,
) {
private val cameraFocusManager by lazy { cameraFocusManagerFactory.create(crashReportTag) }
private var cameraProvider: ProcessCameraProvider? = null

@AssistedFactory
interface Factory {
Expand All @@ -43,9 +44,13 @@ class CameraHelper @AssistedInject constructor(
val providerFuture = ProcessCameraProvider.getInstance(context)
providerFuture.addListener(
{
val cameraProvider = providerFuture.get()
val provider = providerFuture.get().also { provider ->
cameraProvider = provider
provider.unbindAll()
}

// Check if the back camera is available
if (cameraProvider.hasCamera(CameraSelector.DEFAULT_BACK_CAMERA).not()) {
if (provider.hasCamera(CameraSelector.DEFAULT_BACK_CAMERA).not()) {
initializationErrorListener.onCameraError()
return@addListener
}
Expand All @@ -54,7 +59,7 @@ class CameraHelper @AssistedInject constructor(
val preview = buildPreview(cameraPreview)

try {
cameraProvider
provider
.bindToLifecycle(
lifecycleOwner,
cameraSelector,
Expand All @@ -75,6 +80,11 @@ class CameraHelper @AssistedInject constructor(
)
}

fun stopCamera() {
cameraProvider?.unbindAll()
cameraProvider = null
}

private fun buildAnalyser(qrAnalyser: QrCodeAnalyzer) = ImageAnalysis
.Builder()
.setBackpressureStrategy(ImageAnalysis.STRATEGY_KEEP_ONLY_LATEST)
Expand Down