MS-567-improve-sync#785
Conversation
| private fun tagsForDeprecatedWorkers() = listOf( | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_DOWN_COUNTER", // 2023.1.0 | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_DOWNLOADER", // 2023.1.0 | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_END_SYNC_REPORTER", // 2023.1.0 |
There was a problem hiding this comment.
I think reporter workers also should not be cancelled.
meladRaouf
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s and
ybourgery
and removed request for
a team
| "TAG_PEOPLE_SYNC_WORKER_TYPE_DOWN_COUNTER", // 2023.1.0 | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_DOWNLOADER", // 2023.1.0 | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_END_SYNC_REPORTER", // 2023.1.0 | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_START_SYNC_REPORTER", // 2023.1.0 |
There was a problem hiding this comment.
Start and end workers are tied, so it both should be skipped.
|
| "TAG_PEOPLE_SYNC_WORKER_TYPE_START_SYNC_REPORTER", // 2023.1.0 | ||
| "MASTER_SYNC_SCHEDULERS", // 2023.1.0 | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_UP_COUNTER", // 2023.1.0 | ||
| "TAG_PEOPLE_SYNC_WORKER_TYPE_UPLOADER", // 2023.1.0 |
There was a problem hiding this comment.
Why did we add these tags for cleanup in the first place? Were they used for deprecated workers and then reused for the new ones? If that's the case, don't we still want to cancel deprecated workers? If so, we should rename the tags for the current workers instead of removing old ones from cleanup.
There was a problem hiding this comment.
This is intended to stop old workers scheduled in previous versions of
SID to prevent crashes during migration to newer app versions.
There was a problem hiding this comment.
Yes, and with the removal of these tags aren't we regressing to the same situation?
3 participants
[MS-567 Remove uploader and downloader from the deprecated workers](5d2079d)