Skip to content

MS-567-improve-sync #785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meladRaouf merged 3 commits into from
Jul 6, 2024
Merged

MS-567-improve-sync #785

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5d2079d
[MS-567] remove uploaded and downloader from the deprecated workers
meladRaouf Jul 4, 2024
74e0d24
[MS-567] remove END_SYNC_REPORTER from deprecated workers
meladRaouf Jul 4, 2024
fe1779c
[MS-567] remove START_SYNC_REPORTER from deprecated workers
meladRaouf Jul 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions infra/sync/src/main/java/com/simprints/infra/sync/usecase/CleanupDeprecatedWorkersUseCase.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,12 +37,8 @@ internal class CleanupDeprecatedWorkersUseCase @Inject constructor(

private fun tagsForDeprecatedWorkers() = listOf(
"TAG_PEOPLE_SYNC_WORKER_TYPE_DOWN_COUNTER", // 2023.1.0
"TAG_PEOPLE_SYNC_WORKER_TYPE_DOWNLOADER", // 2023.1.0
"TAG_PEOPLE_SYNC_WORKER_TYPE_END_SYNC_REPORTER", // 2023.1.0
"TAG_PEOPLE_SYNC_WORKER_TYPE_START_SYNC_REPORTER", // 2023.1.0
"MASTER_SYNC_SCHEDULERS", // 2023.1.0
"TAG_PEOPLE_SYNC_WORKER_TYPE_UP_COUNTER", // 2023.1.0
"TAG_PEOPLE_SYNC_WORKER_TYPE_UPLOADER", // 2023.1.0
Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we add these tags for cleanup in the first place? Were they used for deprecated workers and then reused for the new ones? If that's the case, don't we still want to cancel deprecated workers? If so, we should rename the tags for the current workers instead of removing old ones from cleanup.

Copy link
Copy Markdown
Collaborator Author

@meladRaouf meladRaouf Jul 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended to stop old workers scheduled in previous versions of
SID to prevent crashes during migration to newer app versions.

Copy link
Copy Markdown
Contributor

@BurningAXE BurningAXE Jul 9, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and with the removal of these tags aren't we regressing to the same situation?

)

}