MS-197 Assemble consent text using activity context instead of application#875
Merged
Merged
Conversation
Contributor
luhmirin-s
commented
Aug 26, 2024
- As per Alex's investigation - When forming the consent text application context was used. The application context is built only on cold start and has English resources loaded regardless of the changed language.
- I flipped the consent text helpers from holding context in the field and receiving data in params to holding configuration in a data class and receiving context as a parameter. The context of the fragment/activity can now be provided when assembling the consent text.
- The activity context is not stored within the helper and is only used to access the strings so there should be no risk of a memory leak.
|
alexandr-simprints
approved these changes
Aug 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

