Skip to content

MS-197 Assemble consent text using activity context instead of application#875

Merged
luhmirin-s merged 1 commit into
mainfrom
feature/MS-197-consent-translation
Aug 27, 2024
Merged

MS-197 Assemble consent text using activity context instead of application#875
luhmirin-s merged 1 commit into
mainfrom
feature/MS-197-consent-translation

Conversation

@luhmirin-s
Copy link
Copy Markdown
Contributor

  • As per Alex's investigation - When forming the consent text application context was used. The application context is built only on cold start and has English resources loaded regardless of the changed language.
  • I flipped the consent text helpers from holding context in the field and receiving data in params to holding configuration in a data class and receiving context as a parameter. The context of the fragment/activity can now be provided when assembling the consent text.
  • The activity context is not stored within the helper and is only used to access the strings so there should be no risk of a memory leak.

@luhmirin-s luhmirin-s requested review from a team, BurningAXE, TristramN, alex-vt, alexandr-simprints, meladRaouf and ybourgery and removed request for a team August 26, 2024 10:41
@cla-bot cla-bot Bot added the ... label Aug 26, 2024
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
9.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@luhmirin-s luhmirin-s merged commit 64ae77b into main Aug 27, 2024
@luhmirin-s luhmirin-s deleted the feature/MS-197-consent-translation branch August 27, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants