MS-785 Using correct context when compiling text with builders#965
Closed
luhmirin-s wants to merge 2 commits into
Closed
MS-785 Using correct context when compiling text with builders#965luhmirin-s wants to merge 2 commits into
luhmirin-s wants to merge 2 commits into
Conversation
Contributor
luhmirin-s
commented
Nov 8, 2024
luhmirin-s
commented
- When the language is changed, the Application context is not restarted and, therefore, does not reload resources. This is fine until we start using it for string building.
- This change ensures that only the activity context is used for manual string building by utilising annotations provided in Hilt and some manual factory calls.
luhmirin-s
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
meladRaouf and
ybourgery
and removed request for
a team
Contributor
Author
|
I have found another fix for it in the main #875 |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.