[MS-732] Fix ProGuard issue causing release build failure with Hilt modules#916
Merged
Conversation
…odules - Added necessary ProGuard rules to prevent Hilt and Dagger classes from being stripped during minification. - Ensured that @Installin annotations and generated components are preserved in release builds.
meladRaouf
requested review from
a team,
BurningAXE,
TristramN,
alex-vt,
alexandr-simprints,
luhmirin-s and
ybourgery
and removed request for
a team
|
alexandr-simprints
approved these changes
Sep 26, 2024
luhmirin-s
approved these changes
Sep 26, 2024
|
|
||
| -keep class retrofit2.** { *; } | ||
| -keep interface retrofit2.** { *; } | ||
|
|
Contributor
There was a problem hiding this comment.
You could also apply the common proguard file in AndroidApplicationConventionPlugin similarly to how it is done in AndroidLibraryConventionPlugin to avoid config duplication.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the release build failure during ProGuard/R8 minification caused by Hilt-generated classes being stripped. The issue is unrelated to KSP, so I will revert the previous PR addressing KSP.