Skip to content

[MS-732] Fix ProGuard issue causing release build failure with Hilt modules #916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meladRaouf merged 1 commit into from
Sep 26, 2024
Merged

[MS-732] Fix ProGuard issue causing release build failure with Hilt modules #916

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions build-logic/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,24 @@
-dontwarn com.simprints.**
# Do not obfuscate the simprints package
-keep class com.simprints.** { *; }
# Hilt
-keep class dagger.hilt.** { *; }
-keep class javax.inject.** { *; }
-keep class dagger.** { *; }

# Prevent ProGuard from removing @Module, @Inject, @Binds, etc.
-keep class **Module { *; }
-keep class **Inject { *; }
-keep class **Provides { *; }
-keep class **Binds { *; }
-keep class **Hilt_** { *; }

# Keep generated Hilt components
-keep class * implements dagger.hilt.internal.GeneratedComponent { *; }

# Keep classes annotated with @InstallIn to prevent them from being removed
-keep @dagger.hilt.InstallIn class * { *; }

# Keep Hilt components and related Dagger generated code
-keep class * extends dagger.hilt.internal.GeneratedComponentManager { *; }
-keep class * extends dagger.hilt.internal.GeneratedComponent { *; }
22 changes: 22 additions & 0 deletions id/proguard-rules.pro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,3 +66,25 @@

-keep class retrofit2.** { *; }
-keep interface retrofit2.** { *; }

Copy link
Copy Markdown
Contributor

@luhmirin-s luhmirin-s Sep 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also apply the common proguard file in AndroidApplicationConventionPlugin similarly to how it is done in AndroidLibraryConventionPlugin to avoid config duplication.

# Hilt
-keep class dagger.hilt.** { *; }
-keep class javax.inject.** { *; }
-keep class dagger.** { *; }

# Prevent ProGuard from removing @Module, @Inject, @Binds, etc.
-keep class **Module { *; }
-keep class **Inject { *; }
-keep class **Provides { *; }
-keep class **Binds { *; }
-keep class **Hilt_** { *; }

# Keep generated Hilt components
-keep class * implements dagger.hilt.internal.GeneratedComponent { *; }

# Keep classes annotated with @InstallIn to prevent them from being removed
-keep @dagger.hilt.InstallIn class * { *; }

# Keep Hilt components and related Dagger generated code
-keep class * extends dagger.hilt.internal.GeneratedComponentManager { *; }
-keep class * extends dagger.hilt.internal.GeneratedComponent { *; }