Skip to content

Fix broken compilation, add m_virtualPlatinum#1

Closed
denizsokmen wants to merge 2 commits intoSphereserver:masterfrom
denizsokmen:master
Closed

Fix broken compilation, add m_virtualPlatinum#1
denizsokmen wants to merge 2 commits intoSphereserver:masterfrom
denizsokmen:master

Conversation

@denizsokmen
Copy link
Copy Markdown
Collaborator

No description provided.

@coruja747
Copy link
Copy Markdown
Collaborator

Don't worry, m_virtualPlatinum got removed on last commit because it's now a virtual value. But it's not completely removed because it still needed on some functions. So instead set separately both gold / platinum values, now we store only the total value to later split it into gold (total % 1.000.000.000) and platinum (total / 1.000.000.000)

I'm rewriting the trade window code and this compiler error will be fixed in some minutes when I send it :D

@coruja747 coruja747 closed this Oct 8, 2015
@denizsokmen
Copy link
Copy Markdown
Collaborator Author

Okay :D

@lintax
Copy link
Copy Markdown
Member

lintax commented Oct 8, 2015

Actually having a build crushed for 10 hours in repository is a bad idea. Especially in master. The main reason why git is good - is almost no cost for branching... Your branch can consist of anything, however development one should be ok.
Best would be to apply patch that fixes the problem, and then make the proposed changes with the refactorings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants