Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #520 +/- ##
============================================
+ Coverage 73.89% 73.90% +0.01%
- Complexity 2901 2912 +11
============================================
Files 500 500
Lines 11717 11747 +30
Branches 651 658 +7
============================================
+ Hits 8658 8682 +24
- Misses 2835 2841 +6
Partials 224 224 |
Contributor
Author
|
@armiol, PTAL. |
armiol
approved these changes
Mar 25, 2020
Collaborator
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@dmdashenkov LGTM with a new comment.
| import static java.util.regex.Pattern.UNICODE_CHARACTER_CLASS; | ||
|
|
||
| /** | ||
| * A constraint, which when applied to a string field, checks whether that field matches the |
Collaborator
There was a problem hiding this comment.
Please document the public API methods, for the sake of uniformity.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we deprecate the
PatternOpntion.flagsfield, which is an integer mask, in favour of themodifiers— a new field which allows specifying regular expression modifiers in a descriptive manner.Fixes this issue.