-
Notifications
You must be signed in to change notification settings - Fork 4
Smarter regex modifiers #520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
2b6c1e7
Update config
dmdashenkov dc48129
Define modifiers
dmdashenkov 93362c4
Adjust validation to account for regex flags
dmdashenkov 2fc9cd2
Update Gradle
dmdashenkov 38822a6
Make modifiers a message and add tests for runtime validation
dmdashenkov a44d6ab
Make test patterns platform-independant
dmdashenkov 01ce0bc
Remove usage of deprecated API
dmdashenkov c5ec0c2
Add doc for public API
dmdashenkov 19945af
Bump base version
dmdashenkov 19191be
Update reports
dmdashenkov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| syntax = "proto3"; | ||
|
|
||
| package spine.test.validate; | ||
|
|
||
| import "spine/options.proto"; | ||
|
|
||
| option (type_url_prefix) = "type.spine.io"; | ||
| option java_package = "io.spine.test.validate"; | ||
| option java_outer_classname = "PatternsProto"; | ||
| option java_multiple_files = true; | ||
|
|
||
| message AllThePatterns { | ||
|
|
||
| string letters = 1 [ | ||
| (pattern).regex = "[a-z]+", | ||
| (pattern).modifier.case_insensitive = true | ||
| ]; | ||
|
|
||
| string many_lines = 2 [ | ||
| (pattern).regex = ".+$\r?\n^.+", | ||
| (pattern).modifier.multiline = true | ||
| ]; | ||
|
|
||
| string partial = 3 [ | ||
| (pattern).regex = "World", | ||
| (pattern).modifier.partial_match = true | ||
| ]; | ||
|
|
||
| string utf8 = 4 [ | ||
| (pattern).regex = "[їґє]", | ||
| (pattern).modifier.unicode = true | ||
| ]; | ||
|
|
||
| string dot_all = 5 [ | ||
| (pattern).regex = ".*", | ||
| (pattern).modifier.dot_all = true | ||
| ]; | ||
| } |
Submodule config
updated
4 files
| +2 −1 | gradle/dependencies.gradle | |
| +11 −21 | gradle/js/build-tasks.gradle | |
| +219 −0 | gradle/update-gh-pages.gradle | |
| +4 −0 | scripts/register-ssh-key.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.2.2-bin.zip | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-6.3-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please document the public API methods, for the sake of uniformity.