Merged
Conversation
The `javax.annotation-api` dependency is required for all modules that are using the annotations from the `javax.annotation` package, e.g. `javax.annotation.Generated`.
We're not supporting `pull.bat` in the `config` anymore and expect developers to use `WSL` or other linux-like build environments.
dmdashenkov
approved these changes
Jun 18, 2020
Codecov Report
@@ Coverage Diff @@
## master #546 +/- ##
============================================
+ Coverage 73.80% 73.82% +0.01%
- Complexity 2958 2959 +1
============================================
Files 506 506
Lines 11972 11972
Branches 669 669
============================================
+ Hits 8836 8838 +2
+ Misses 2908 2907 -1
+ Partials 228 227 -1 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR I have added the
javax.annotations-apidependency to our plugins that rely on the usage of thejavax.annotationspackage, e.g. thejavax.annotations.Generated.The dependency is required due to the absence of the noted package in the JDK11+.