Migrate to CallerFinder from reflect#87
Merged
alexander-yevsyukov merged 36 commits intomasterfrom May 6, 2024
Merged
Conversation
Also: * Address warnings for explicit `var`s. * Remove unused import.
Also: * Remove `JavadocConfig` in `kmp-module` because `javadoc` task is no longer available. * Make `FastTest` and `SlowTest` tasks `abstract` again to conform to new Gradle API. * Bump Kotlin used by Gradle to `1.9.22` as stated for [Gradle v8.7](https://docs.gradle.org/current/release-notes.html#kotlin-dsl-improvements).
... to avoid the build warning. See https://youtrack.jetbrains.com/issue/KT-61573 for details.
This reverts commit 4a702c2.
armiol
requested changes
May 6, 2024
Contributor
armiol
left a comment
armiol
left a comment
There was a problem hiding this comment.
@alexander-yevsyukov please see my comments. I am also requesting the review, since the version increment check failed.
buildSrc/src/main/kotlin/io/spine/internal/gradle/ProjectExtensions.kt
Outdated
Show resolved
Hide resolved
The task may not be available in a non-Java project. Also: * Update (c) year.
armiol
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addressed the issue #6 migrating to
CallerFinderwhich recently moved toreflectsubproject.Other notable changes
configwas applied.8.7.Project.buildDirproperty.-Xexpect-actual-classesto Kotlin compiler args to avoid build time warnings onexpect/actualclasses.getFluentLogger()of actual JVM classLoggingFactorywas removed because there are no longer calls to in the whole GitHub organisation.Future work
It is expected that this PR overlaps with #83 in terms of dependencies and
config.#83 will be analysed against new
masterafter this PR is merged.