Bring CallFinder from Logging#6
Merged
alexander-yevsyukov merged 23 commits intomasterfrom May 6, 2024
Merged
Conversation
Also: * Improve method names.
This way they better describe the parameters.
armiol
approved these changes
May 6, 2024
armiol
approved these changes
May 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings the class
CallerFinderfrom Logging framework (neeio.spine.logging.flogger.util.CallerFinder) to become the part ofreflectlibrary.The reason for starting this transition is that we have already the second occasion for the feature of knowing a class calling another class. More specifically, the need for such an ability was discovered when developing
PipelineSetuputility in ProtoData. We need to know the class which creates an instance ofPipelineSetupso that we can use theClassLoaderof the class for loading its resources from withinPipelineSetupinstance.Apart from brining
CallerFinderand related classes and tests, the associated code in Java was converted to Kotlin.Also the following refactorings were made:
CallerFinder.getStackForCallerOf()was renamed tostackForCallerOf().StackGetter.getStackForCaller()was renamed tostackForCaller().Future actions