Skip to content

Conversation

@mxmader
Copy link

@mxmader mxmader commented Jul 29, 2017

The CloudFormation.create_stack method expects the tags argument to be a dict, and should be represented by object in this schema. Verified this against the aws pack v0.11.0.

The `CloudFormation.create_stack` method expects the `tags` argument to be a `dict`, and should be represented by `object` in this schema. Verified this against the aws pack v0.11.0.
@LindsayHill
Copy link
Contributor

Thanks @mxmader - can you do a minor version bump in pack.yaml and add a line to CHANGES.md?

@LindsayHill
Copy link
Contributor

Actually, thinking about it a bit more - @warrenvw do we need to make a tweak to the AWS action generation code here?

@warrenvw
Copy link
Contributor

warrenvw commented Jul 31, 2017

@LindsayHill You're right - the YAML files should not be modified manually.

Upon investigation, I don't think there's anything that needs to change here. Please use cloudformation_create_stack instead of cf_create_stack. It looks as though the service has been renamed by boto itself. The tags parameter in cloudformation is now officially mapped to the python type array.

NOTE: We should consider marking the retired/renamed services deprecated and remove them from the stackstorm-aws pack. But I believe that is outside the scope of this PR. I'll open an issue in this regard tomorrow.

@mxmader
Copy link
Author

mxmader commented Jul 31, 2017

@warrenvw awesome - thanks for the pointer. i'll test the cloudformation_create_stack action. i'll close this PR upon citation of the new issue you mentioned.

@warrenvw
Copy link
Contributor

@mxmader I'm closing this PR. Reopen if necessary.

@warrenvw warrenvw closed this Aug 12, 2017
@mxmader
Copy link
Author

mxmader commented Aug 13, 2017

Was an issue opened covering the deprecation of the retired/renamed services?

@mxmader mxmader deleted the patch-1 branch August 13, 2017 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants