Update icinga_state_change_events.py

[tortuegenialez]

   Add a variable in the payload sensor to easily differenciate host and service type for a state change

Signed-off-by: Atlantis Boengkih atlantis.boengkih@blade-group.com

[blag]

I'm not too familiar with this pack or service, will the event JSON ever have both service and host keys specified? Or is it pretty well guaranteed that they won't ever be specified together?

[tortuegenialez]

The event generated by Icinga is either a service event or a host event, it can not be both.

[blag]

This is not a backwards-compatible change, right? Previously both the service and host keys would exist in the payload, but now only one will. This could break rules that already exist and rely on both keys existing (even if one of them isn't useful).

I think I'd like to maintain backwards compatibility (eg: keep both service and host keys in payload), and simply add a key (eg: check_type) that makes it easier to query.

Pulling in @armab, since he might have some opinions on this.

[arm4b]

I'm good with the @blag request to keep the backwards compatibility, if possible.

[nzlosh]

@atl-tortue, we can add the host line in the service block and it will ensure backward compatibility and prevent exceptions being raised for host event types.

        if 'service' in event:
            payload['host'] = event['host']
            payload['service'] = event['service']
            payload['check_type'] = 'service'

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[nzlosh]

Closing due to PR being abandoned.