Skip to content

Conversation

@nzlosh
Copy link
Contributor

@nzlosh nzlosh commented Feb 14, 2020

This pull requests supersedes #11

  • Use patched icinga2api for Python3 support because upstream is unresponsive. nzlosh/python-icinga2api@f59d6cd
  • Generate documentation with pack2md
  • Format code using Black
  • Service field is now optional (returns "n/a" when statechange event doesn't have a service field)
  • Timestamp field is now sent in the StackStorm trigger to allow for detection of lag in events.
  • Version bump to 0.6.0 along with changelog update.

@blag
Copy link
Contributor

blag commented Feb 14, 2020

Awesome, thanks!

Can you add build_and_test_python36 to the requires list here:

workflows:
  version: 2
  # Workflow which runs on each push
  build_test_deploy_on_push:
    jobs:
      - build_and_test_python27
      - build_and_test_python36
      - deploy:
          requires:
            - build_and_test_python27
            - build_and_test_python36  # <--
          filters:
            branches:
              only: master

That will ensure that the pack is only ever deployed if both the Python 2 and 3 tests pass.

@nzlosh
Copy link
Contributor Author

nzlosh commented Feb 17, 2020

@blag ☝️ Python36 added as requested.

@blag blag merged commit 9fdc8af into StackStorm-Exchange:master Feb 19, 2020
@blag
Copy link
Contributor

blag commented Feb 19, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants