Move babel-eslint to devDependencies instead of dependencies #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
approved these changes
Jun 21, 2019
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
LGTM
It was added a few days ago by @m4dcoder https://github.com/StackStorm/hubot-stackstorm/pull/171/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R24 so not sure what was context here?
From my side it's still worth to include a small changelog record about reducing dependencies list.
Contributor
Author
|
Added a dashes line under the |
Contributor
Author
|
@armab Added an entry to the changelog. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should help reduce the size of the diff of
npm-shrinkwrap.jsonin StackStorm/st2chatops#128.