Skip to content

Update npm-shrinkwrap.json with new hubot-stackstorm #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jinpingh merged 2 commits into from
Jun 24, 2019
Merged

Update npm-shrinkwrap.json with new hubot-stackstorm #128

jinpingh merged 2 commits into from
Jun 24, 2019

Conversation

@blag
Copy link
Contributor

@blag blag commented Jun 21, 2019 •
edited by arm4b
Loading

Follow-up to #127 which missed npm-shrinkwrap.json update

@blag blag requested a review from arm4b June 21, 2019 00:41
@arm4b
Copy link
Member

arm4b commented Jun 21, 2019

Yeah, there is a way to regenerate shrinkwrap with minimal changes, not all possible deps. Otherwise that diff will break things.

@blag
Copy link
Contributor Author

blag commented Jun 21, 2019

The babel-eslint package has somehow snuck into packages.json, and subsequently into this npm-shrinkwrap.json when I updated it. I'm pretty sure that babel-eslint should go in the devDependencies section instead. That should (I think) drastically reduce the size of this diff once I regenerate npm-shrinkwrap.json.

@armab @LindsayHill @m4dcoder Any objections?

@blag blag mentioned this pull request Jun 21, 2019
Merged
@arm4b arm4b force-pushed the update-npm-shrinkwrap branch from df3532c to 3f3dcae Compare June 21, 2019 19:42
@arm4b
Copy link
Member

arm4b commented Jun 21, 2019 •
edited
Loading

Yeah, finally found #104 where we documented npm-shrinkwrap update process with minimal diff.
Pushed 3f3dcae that should do it.

arm4b
arm4b approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jinpingh jinpingh merged commit b4c5a17 into master Jun 24, 2019
@jinpingh jinpingh deleted the update-npm-shrinkwrap branch June 24, 2019 16:33
@arm4b arm4b mentioned this pull request Jan 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@arm4b arm4b arm4b approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@blag @arm4b @jinpingh