Skip to content

Conversation

@blag
Copy link
Contributor

@blag blag commented Jan 11, 2020

Updates npm-shrinkwrap.json with new hubot-stackstorm 0.10.1 release, which created an npm-shrinkwrap.json file without its devDependencies.

The new npm-shrinkwrap.json file for this project no longer includes its devDependencies either.

The hubot-spark package, on the other hand, still depends on babel-polyfill, even in production. 👍

@blag blag requested a review from arm4b January 11, 2020 01:47
@blag
Copy link
Contributor Author

blag commented Jan 11, 2020

Should reduce the number of vulnerable dependencies noted in #135.

@arm4b
Copy link
Member

arm4b commented Jan 11, 2020

Doesn’t look it fixes any build failures :/

@blag
Copy link
Contributor Author

blag commented Jan 11, 2020

Something is wrong with CircleCI. The "Build packages" step completes successfully before the tests finish running:

While tests are running

But then once tests finish running, somehow that same build step supposedly fails with a completely different output:

Once tests are finished

@arm4b
Copy link
Member

arm4b commented Jan 17, 2020

Per #139 npm-shrinkwrap wasn't the root cause of the build failure.

For some long time we tried to keep the diff minimal while updating dependencies via this method: #104. See #128 for the history.

With diff +736 −2,328 I think it will explode with so many dependencies updated, as experienced before.
Let's please try to keep the shrinkwrap diff minimal. Alternative is to postpone it until the next release. Even if we do 3.2, - it'll be already a huge one that may break many things ... because of the reasons.

@blag blag closed this Apr 12, 2020
@blag blag deleted the update-npm-shrinkwrap branch April 12, 2020 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants