Skip to content

Conversation

@punkrokk
Copy link
Member

@punkrokk punkrokk commented Jan 17, 2020

Some recent nodejs/npm update introduced regression resulting in failed builds due to permissions issue, ex: https://circleci.com/gh/StackStorm/st2chatops/761

  • Made a change in Makefile to chown the /root/st2chatops to be owned by root:root fixing the breaking npm --install perms issues in current builds

Closes #136

@punkrokk punkrokk requested a review from arm4b January 17, 2020 04:22
@arm4b arm4b changed the title update perms in makefile Fix the nodejs build: update perms in makefile Jan 17, 2020
@arm4b arm4b added the bug label Jan 17, 2020
Copy link
Member

@arm4b arm4b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! 👍

Thanks for fixing the st2chatops builds in master.

@arm4b arm4b merged commit 2ec54c9 into master Jan 17, 2020
@arm4b arm4b deleted the upstream-perms branch January 17, 2020 11:22
@blag
Copy link
Contributor

blag commented Jan 17, 2020

👍 Thanks!

@arm4b arm4b mentioned this pull request Jan 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants