Use yaml.safe_load instead of yaml.load #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=======================================
Coverage 94.33% 94.33%
=======================================
Files 35 35
Lines 1908 1908
Branches 380 380
=======================================
Hits 1800 1800
Misses 65 65
Partials 43 43
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same change as in StackStorm/st2#4223.
There is no need to use
yaml.loadwhen loading workflow definition files since we only support simple types there (integers, strings, lists, etc.).yaml.safe_loadis preferred in such scenarios andyaml.loadcould present security issues since it also supports loading arbitrary Python objects.