Use yaml.safe_load instead of yaml.load #4223
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Tweet made me grep our code for
yaml.load- https://twitter.com/anthonypjshaw/status/1014054816987803648I was almost positive we already use
yaml.safe_loadeverywhere, but it looks like a couple ofyaml.loadoccurrences managed to creep into the tests.It's not a big deal to do that in the tests. It's mostly problematic in places where we take user input, but it's still a good practice to use
yaml.safe_loadif there is no special reason / need to useyaml.load.Thanks @tonybaloney