Skip to content

Conversation

@Kami
Copy link
Member

@Kami Kami commented Jul 3, 2018

This Tweet made me grep our code for yaml.load - https://twitter.com/anthonypjshaw/status/1014054816987803648

I was almost positive we already use yaml.safe_load everywhere, but it looks like a couple of yaml.load occurrences managed to creep into the tests.

It's not a big deal to do that in the tests. It's mostly problematic in places where we take user input, but it's still a good practice to use yaml.safe_load if there is no special reason / need to use yaml.load.

Thanks @tonybaloney

@arm4b
Copy link
Member

arm4b commented Jul 3, 2018

@tonybaloney's original #4222 was first 😛

@Kami
Copy link
Member Author

Kami commented Jul 3, 2018

@armab ah, lol, I didn't even see that one. Will close this one as a duplicate of #4222.

Or maybe Github just doesn't correctly handle nano second precision and I was actually the first one :trollface:

@Kami Kami closed this Jul 3, 2018
@Kami Kami deleted the yaml_load_and_safe_load branch July 3, 2018 11:02
@arm4b
Copy link
Member

arm4b commented Jul 3, 2018

looks like it's 6 mins in diff between 2 PRs :)

@Kami
Copy link
Member Author

Kami commented Jul 3, 2018

@armab No way - must be that we were routed to two different backend servers with local clocks out of sync :trollface:

@arm4b
Copy link
Member

arm4b commented Jul 3, 2018

Haha 😄 , that's a good one 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants