Improve error handling when building / pushing images #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arm4b
approved these changes
Feb 22, 2021
Member
arm4b
left a comment
arm4b
left a comment
There was a problem hiding this comment.
Looks good,
Thanks for the enhancement! 👍
There is no need to create a dedicated issue though if there is a plan to create a PR like this immediately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a small improvement to the error handling and does no longer rely on a fix string to identify errors. Instead any output that does not match the supported values 0, 1, 2 or 3 will be handled as exception and cause the make command to fail.
!close #43