Skip to content

Improve error handling when building / pushing images #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arm4b merged 3 commits into from
Feb 22, 2021
Merged

Improve error handling when building / pushing images #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
613aa36
Improve the error handling on the Makefile and don't rely on a fix st…
winem Feb 17, 2021
c7d72cb
Handle comment regarding the supported output for future maintainers
winem Feb 17, 2021
c9baf0b
Update the supported values to include 0
winem Feb 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ endif

verify_tag_update_flag:
ifeq ($(RELEASE_VERSION), true)
ifneq ($(shell echo "${TAG_UPDATE_FLAG}" | grep -E "Error:"),)
ifneq ($(shell echo "${TAG_UPDATE_FLAG}" | grep -vE "^[0-3]"),)
@echo -e "Failed to identify the tags to be set."
@echo -e "\033[31mNo images were tagged due to an error when determining the correct tags: ${TAG_UPDATE_FLAG}\033[0m"
exit 1
Expand Down
4 changes: 4 additions & 0 deletions determine_needed_tags.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
#!/usr/bin/env bash

# See showHelp() for the supported output values if everything goes fine.
# $(make) will handle any other output as unexpected and assume an error.
# Use this to raise error and cause the CI to fail.

# the first argument must be the name of the container, i.e. st2, st2actionrunner, st2stream
component=$1
# the 2nd argument is the version of the current build and expects at least major.miinor to be provided
Expand Down