Added runner requirements to package #562
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on StackStorm/st2#4169 a new
runnerfor StackStorm. I noticed that therequirements.txtfile in therunnersdirectory wasn't actually being used to install any packages into the virtualenv.This fix goes along with the fix in
https://github.com/StackStorm/st2/pull/4169which pulls in all of the runnerin-requirements.txtfiles into the mainst2virtualenv during testing.This is also necessary during packaging so the
runnerrequirements are met when the package is deployed.I believe the st2 PR is required to be merged in order for this one to work, since previously the
runnersdid not includein-requirements.txtfiles that are now used by st2-packages.