Also include runners in-requirements.txt when generating final requirements files #579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before new winrm runner, runners didn't have their own specific requirement so things worked. Now we need to include runner requirement if we want winrm runner to work.
Kami
force-pushed
the
include_runner_requirements
branch
from
019958e to
193ee65
Compare
Member
|
Looks like a duplicate of #562 |
Member
Author
arm4b
approved these changes
Jul 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found yet another issue while working on a big rabbit hole called new winrmi runner tests and related work.
Before those changes, we didn't have any runner with a dependency / requirement which is not part of any other component so things worked out of the box.
Now new winrm runner depends on the
pywinlibrary and we need to take this into account when generating finalrequirements.txtotherwise this requirement will be skipped and packages won't be completed (pywinrmrequirement will be missing).Closes #562