Remove st2mistral packaging and builds #656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Draft still - as need to do some manual testing, but wanted circleci feedback. |
arm4b
suggested changes
Jul 31, 2020
Member
There was a problem hiding this comment.
Thanks!
Similar to #654, would be easier to split such a big change into 2 separated PRs:
- remove mistral from the scripted installer, CircleCI, Readme update, see #654
- deeper-level packaging/makefile/etc changes (this PR)
It's easier to start with 1 first. This will be more convenient to review, track and switch-context.
arm4b
changed the title
25 tasks
Member
|
Thanks for splitting those PRs! |
amanda11
changed the title
arm4b
reviewed
Aug 10, 2020
| RUNNERS := $(shell ls -I mistral* ../contrib/runners) | ||
| else ifeq ($(EL_VERSION),8) | ||
| # Don't include Mistral runner | ||
| # TODO: Go back to all runners when mistral removed from st2 |
Member
There was a problem hiding this comment.
As I understand we'll need another PR in st2-packages, once the mistral removal happens in the st2 repository.
Contributor
Author
There was a problem hiding this comment.
Yes - it's a bit chicken and egg. It will still work when we take out mistral from contrib/runners in ST2 - but we should tidy up afterwards.
But this code can be used before and after the ST2 changes.
This was referenced Aug 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removal of postgres and mistral from packages, docker and vagrant
Scripted-installer changes are not included.
Addresses st2-packages of StackStorm/st2#4762
Closes #121, closes #487, closes #474, closes #455, closes #421