WIP: OpenAPI spec linter #3376
Closed
WIP: OpenAPI spec linter #3376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 24, 2017 16:15
Kami
reviewed
Apr 28, 2017
| status: | ||
| description: The current status of the action execution. | ||
| type: string | ||
| enum: {{ LIVEACTION_STATUSES }} |
Member
There was a problem hiding this comment.
To confirm - this file is automatically generated based on .j2 definition on make target and build?
Contributor
Author
There was a problem hiding this comment.
I haven't hooked up a make target yet. I plan to do that.
Member
|
So far LGTM 👍 Can you please gist the sample output? |
added 2 commits
May 3, 2017 16:31
Member
|
LGTM for now once the tests pass. Next step will be fixing / addressing all the errors :P |
Kami
approved these changes
May 4, 2017
added 2 commits
June 9, 2017 15:00
* master: (208 commits) adding bug fix to the end of changelog message Adding changelog entry Adding simple test Adding percent parsing and various debug messages Lint and unit tests fixes Enable trigger parameters validation check Change sleep time for the worker shutdown test Name is required, ref is optional Trigger and TriggerType models should have ref field Revert unneeded changes Cleanup log changes Log debug rule query Revert back trigger to StringField in trigger instance Fix duplicate remove from running liveactions set Checkpoint #3 Checkpoint #2 Checkpoint Minor fix to mistral itests action raises ValueError for unknown uuid type. Fixes test and added enum to meta Fix style - use 4 spaces for a tab, throw instead of returning false. ...
Contributor
Author
|
Closing. Opened #3462 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Output