OpenAPI spec linter #2 (Circle CI check) #3462
Conversation
* master: (208 commits) adding bug fix to the end of changelog message Adding changelog entry Adding simple test Adding percent parsing and various debug messages Lint and unit tests fixes Enable trigger parameters validation check Change sleep time for the worker shutdown test Name is required, ref is optional Trigger and TriggerType models should have ref field Revert unneeded changes Cleanup log changes Log debug rule query Revert back trigger to StringField in trigger instance Fix duplicate remove from running liveactions set Checkpoint #3 Checkpoint #2 Checkpoint Minor fix to mistral itests action raises ValueError for unknown uuid type. Fixes test and added enum to meta Fix style - use 4 spaces for a tab, throw instead of returning false. ...
|
So far LGTM 👍 |
lakshmi-kannan
changed the title
|
We're not including these new checks in CircleCI yet? |
@armab Not yet. Then the CI will always fail :P. This is for kami to identify which openapispec models miss a X-API-Model parameter. He cannot eye-ball it apparently. |
|
Looks like you added make target but you didn't actually add this target run to Circle CI. Is this intentional? I kinda assume we perhaps want to add it to Circle CI, but make failures non-fatal until we address all the issues, then we turn failures into fatal build failures. Edit: Looks like @armab had the same question above :P |
|
LGTM |
requirements.txt
Outdated
| oslo.utils<3.1.0 | ||
| paramiko<2.2,>=2.1.2 | ||
| passlib==1.6.5 | ||
| prance |
There was a problem hiding this comment.
Do we need to add corresponding entry to some component in-requirements.txt and fixed-requirements.txt since this file is auto-generated?
Makefile
Outdated
| @echo | ||
| @echo "================== Lint API spec ====================" | ||
| @echo | ||
| st2common/bin/st2-validate-api-spec --generate |
There was a problem hiding this comment.
Also a good idea to activate virtualenv here, same as we do for other tasks - . $(VIRTUALENV_DIR)/bin/activate; command
* master: (59 commits) Add echo. Fix more syntax issues in changelog file. Fix syntax error. Add rst-check make target which checks CHANGELOG.rst for syntax errors and run it on Circle CI. Add rstcheck to test requirements file. Update changelog. Improve comments. Update config loader so a default value for an attribute from a config schema is set even if attribute has required: false. Enable "--notablescan" MongoDB option on Circle CI. Add more missing indexes. Update mongodb args. Add method back. Inherit from uid mixin class. Add more missing indexes, remove unncessary get_uid method. Add more missing indexes. Update changelog. Add more missing indexes. Add some missing indexes which were found by running MongoDB with --notablescan option. Use latest stable version of MongoDB (3.2.14, 3.4.4) when running tests on Circle CI. Diable wired tiger statistics to speed up tests. ... Conflicts: Makefile
4 participants
Opened in favor of #3376
Output