Fix a bug with "{{ config_text.foo }}" not working for executions scheduled via Orquesta workflow #4531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"pack" attribute to the execution context.
If we don't add that, {{ config_context }} won't work correctly for
default parameter values for action executions which are scheduled as
part of an Orquesta workflow.
Kami
commented
Feb 4, 2019
| """Returns config for given pack and user. | ||
| """ | ||
| LOG.debug('Attempting to get config') | ||
| LOG.debug('Attempting to get config for pack "%s" and user "%s"' % (pack, user)) |
Member
Author
There was a problem hiding this comment.
Originally this log message was not all that useful because it didn't include pack and username so you weren't able to spot pack is None just by looking at the log messages.
sure also also add "pack" attribute to LiveActionDB.context attribute inside "create_request" function. We already add it in RunnerContainer.dispatch(), but that's not the best place since some tests don't call that method so that value won't be present.
execution context.
default parameter values works for executions scheduled via Orquesta workflow.
Kami
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug with
{{ confix_context.<config item name> }}notation not working for action parameter default values for action executions which are scheduled via Orquesta (aka part of an Orquesta workflow).Background and Details
I was working on some st2community pack changes and improvements and while testing and developing the workflow I noticed "{{ config_context }}" notation doesn't work for executions scheduled via Orquesta (e.g. https://github.com/StackStorm/stackstorm-st2community/pull/1/files#diff-3c8d6de4c078da34b194a061826b147dR13), but it works just fine if those actions are run outside of the Orquesta workflow context.
After some digging in, I found orquesta runner doesn't add
packvalue to the execution context soget_configmethod will always return an empty dict because pack will be set toNone.TODO