-
Notifications
You must be signed in to change notification settings - Fork 5
Include information about new forum posts in a daily support summary report #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
forum.stackstorm.com.
data from multiple sources and renders it as a Slack message. Also update Github issue and pr retrieval code so it's also more efficient (we only retrieve issues once, filtering is performed server side, etc).
|
Alright, I totally refactored the main action as per my comment above. We now have one main action which is responsible to retrieve daily summary and statistics from various sources and then render it via Jinja template to be used as a Slack message. In addition to that, I made many other changes and improvements:
Even though everything is faster and more efficient now, I think it would probably still be a good idea to use some kind of per Github user / organization repo whitelist. Both organizations we query have tons of repos so it still results in a lot of API calls ( * <number of Github users we query info for). I still plan to do some more refactoring and improvements, but that's a start which will enable us to more easily add data from other places / sources. |
|
Alright, I'm done with the refactoring and this PR is now ready to review. I made everything more generic and composable. We now have 4 actions:
With those changes in place, it should also be relatively easy to add any addition / new info it (need to add new action which retrieves new data and update assemble_message, workflow and the Jinja template file). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Make sure to bump pack version.
|
I need to apply some workaround until this PR is deployed to cicd - StackStorm/st2#4531. Will revert those once that PR is deployed to cicd. |

Just a quick hack which also includes information about new forum posts.
Before we can merge this, the whole pack will need a bit of re-thinking and refactor since right now it's designed for Github only use case.
I propose changing to a single rule and "post_daily_summary_rule" action combines data from the following actions: